V15: Dont seed when in upgrade mode, and maintenance page is enabled #17275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
So a bug was discovered upgrading from 13 to 15, with seeding running while we are migrating, thus causing errors.
The solution is to only run the seeding, when we are in run mode.
There is however one case were we want to run seeding, and that is when you have the maintenance page disabled, (as in, you still want to access the site while in upgrade state, and thus we want that content to be seeded).
I do however think this case is fine to get errors, as this would also be the case when accessing content, where the data models no longer match, and thus would cause errors anyways.
How to test